Avoid panics for implicitly concatenated forward references #3700

charliermarsh · 2023-03-23T22:45:23Z

Summary

Right now, annotations like """List[int]"""'☃' can cause a panic, since we assume that the start and end quotes for a string are "aligned" -- which isn't the case for implicit concatenations. This PR makes the checks a bit more defensive.

charliermarsh · 2023-03-23T22:46:06Z

crates/ruff_python_ast/src/str.rs

+pub fn raw_contents(contents: &str) -> Option<&str> {
+    let leading_quote_str = leading_quote(contents)?;
+    let trailing_quote_str = trailing_quote(contents)?;
+    Some(&contents[leading_quote_str.len()..contents.len() - trailing_quote_str.len()])


I wish this returned None for implicit concatenations.

github-actions · 2023-03-23T23:09:05Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.8±0.25ms     2.4 MB/sec    1.02     17.2±0.35ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.4±0.09ms     3.8 MB/sec    1.01      4.4±0.11ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   608.2±13.03µs     4.9 MB/sec    1.03   626.4±25.41µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.4±0.14ms     3.4 MB/sec    1.03      7.6±0.21ms     3.3 MB/sec
linter/default-rules/large/dataset.py      1.01      8.9±0.31ms     4.6 MB/sec    1.00      8.8±0.13ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1962.7±39.90µs     8.5 MB/sec    1.02  1998.3±88.83µs     8.3 MB/sec
linter/default-rules/numpy/globals.py      1.00   240.3±10.54µs    12.3 MB/sec    1.01   241.7±14.79µs    12.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.2±0.11ms     6.1 MB/sec    1.03      4.3±0.34ms     6.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     12.7±0.07ms     3.2 MB/sec    1.00     12.7±0.08ms     3.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.06ms     5.1 MB/sec    1.00      3.3±0.01ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    372.5±1.65µs     7.9 MB/sec    1.00    372.0±2.00µs     7.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.5±0.03ms     4.7 MB/sec    1.00      5.5±0.09ms     4.7 MB/sec
linter/default-rules/large/dataset.py      1.00      7.0±0.02ms     5.8 MB/sec    1.01      7.1±0.02ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1470.4±4.96µs    11.3 MB/sec    1.01   1479.0±7.58µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    152.0±0.88µs    19.4 MB/sec    1.02    155.5±4.63µs    19.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.02ms     8.0 MB/sec    1.01      3.2±0.03ms     7.9 MB/sec

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.259` -> `^0.0.260` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)  #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` -> `==0.0.260` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)  #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` -> `==0.0.260` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/compatibility-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.260/confidence-slim/0.0.259)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260)  #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

charliermarsh commented Mar 23, 2023

View reviewed changes

charliermarsh force-pushed the charlie/implicit-annotations branch 2 times, most recently from b6678e9 to be7d877 Compare March 23, 2023 22:49

Base automatically changed from charlie/f-string-annotations to main March 23, 2023 22:51

charliermarsh force-pushed the charlie/implicit-annotations branch from be7d877 to 661b796 Compare March 23, 2023 22:54

Avoid panics for implictly concatenated forward references

fe6162f

charliermarsh force-pushed the charlie/implicit-annotations branch from 661b796 to fe6162f Compare March 23, 2023 22:54

charliermarsh merged commit 0f95056 into main Mar 23, 2023

charliermarsh deleted the charlie/implicit-annotations branch March 23, 2023 23:13

chenrui333 mentioned this pull request Mar 30, 2023

ruff 0.0.260 Homebrew/homebrew-core#127014

Merged

renovate bot mentioned this pull request May 18, 2023

chore(pre-commit): update ruff to v0.0.272 scop/hashpipe#122

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid panics for implicitly concatenated forward references #3700

Avoid panics for implicitly concatenated forward references #3700

charliermarsh commented Mar 23, 2023

charliermarsh Mar 23, 2023

github-actions bot commented Mar 23, 2023 •

edited

Avoid panics for implicitly concatenated forward references #3700

Avoid panics for implicitly concatenated forward references #3700

Conversation

charliermarsh commented Mar 23, 2023

Summary

charliermarsh Mar 23, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 23, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

github-actions bot commented Mar 23, 2023 •

edited