Fix SIM118 auto-fix #3695
Merged
Fix SIM118 auto-fix #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonathanPlasse
commented
Mar 23, 2023
JonathanPlasse
commented
- Close SIM118 Incorrect error message and autofix #3690
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Mar 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.259` -> `^0.0.260` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@​leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@​JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@​astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@​leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@​JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@​astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
Mar 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` -> `==0.0.260` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@​leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@​JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@​astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@​leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@​JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@​astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMy4zIiwidXBkYXRlZEluVmVyIjoiMzUuMjMuMyJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
Apr 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.259` -> `==0.0.260` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.260`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.260) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.259...v0.0.260) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-bugbear`] Add more immutable functions for `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3764 - \[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` by [@​rouge8](https://togithub.com/rouge8) in [astral-sh/ruff#3794 - \[`flake8-bugbear`] Expand the scope of useless-expression (B018) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3455 - \[`flake8-bugbear`]: Implement rule `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3680 - \[`flake8-gettext`] Implement `flake8-gettext` by [@​leiserfg](https://togithub.com/leiserfg) in [astral-sh/ruff#3785 - \[`flake8-logging-format`] Add support for `.log(level, msg)` calls in `flake8-logging-format` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3726 - \[`flake8-logging-format`] Allow aliased `logging` module as a logger candidate by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3718 - \[`flake8-pyi`] Add autofix for `PYI014` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3729 - \[`flake8-pyi`] Implement `PYI012` by [@​JBLDKY](https://togithub.com/JBLDKY) in [astral-sh/ruff#3743 - \[`flake8-pyi`] Implement `PYI015` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3728 - \[`flake8-simplify`] Fix SIM222 and SIM223 false negative by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3740 - \[`isort`]: support submodules in known\_(first|third)\_party config options by [@​astaric](https://togithub.com/astaric) in [astral-sh/ruff#3768 - \[`pycodestyle`] Use unicode-width to determine line-length instead of character count by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3714 - \[`pydocstyle`] Implement autofix for `D403` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3731 - \[`pylint`] Avoid `useless-import alias` (`C0414`) in `.pyi` files by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3761 - \[`pylint`] Exempt `PLR1711` and `RET501` if non-`None` annotation by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3705 - \[`tryceratops`] Exempt return with side effects for TRY300 by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3780 ##### Bug Fixes - Avoid parsing `ForwardRef` contents as type references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3698 - Avoid parsing f-strings in type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3699 - Include `with` statements in complexity calculation by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3771 - Use import alias locations for `pep8-naming` import rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3772 - Allow `TID252` to fix all valid module paths by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3796 - Fix SIM118 auto-fix by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3695 - Avoid panics for implicitly concatenated forward references by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3700 - Allow simple container literals as default values by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3703 - Traverse over nested string type annotations by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3724 - Use `wild::args()` and add `wild` as a dependency by [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) in [astral-sh/ruff#3739 - Avoid overlong-line errors for lines that end with URLs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3663 - Sort statistics by count by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3748 - Reduce explicit clones by [@​MichaReiser](https://togithub.com/MichaReiser) in [astral-sh/ruff#3793 - Add flymake-ruff to docs by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3800 #### New Contributors - [@​agriyakhetarpal](https://togithub.com/agriyakhetarpal) made their first contribution in [astral-sh/ruff#3739 - [@​leiserfg](https://togithub.com/leiserfg) made their first contribution in [astral-sh/ruff#3741 - [@​JBLDKY](https://togithub.com/JBLDKY) made their first contribution in [astral-sh/ruff#3743 - [@​astaric](https://togithub.com/astaric) made their first contribution in [astral-sh/ruff#3768 **Full Changelog**: astral-sh/ruff@v0.0.259...v0.0.260 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.