feat: update C416 with dict comprehension (autofixable)

[dhruvmanila]

Update C416 with dict comprehensions which is auto-fixable.

This required changing the function signature of unnecessary_comprehension to take a vector of elements as a dict comprehension has 2 of them (key, value). Look at review comments

resolves: #3598

[github-actions]

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+10, -0, 0 error(s))

airflow (+7, -0)

+ airflow/api/common/experimental/get_lineage.py:50:25: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ airflow/models/dagrun.py:281:16: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ airflow/operators/python.py:386:37: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ airflow/www/decorators.py:103:26: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ docs/conf.py:410:29: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ docs/conf.py:411:15: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ docs/conf.py:413:39: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)

cibuildwheel (+1, -0)

+ test/test_dependency_versions.py:48:12: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)

zulip (+2, -0)

+ zerver/lib/onboarding.py:26:18: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)
+ zerver/management/commands/makemessages.py:280:27: C416 [*] Unnecessary `dict` comprehension (rewrite using `dict()`)

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.0±0.53ms     2.7 MB/sec    1.00     14.9±0.59ms     2.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.8±0.12ms     4.4 MB/sec    1.07      4.1±0.13ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   544.2±33.72µs     5.4 MB/sec    1.04   563.7±26.56µs     5.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.8±0.27ms     3.8 MB/sec    1.03      7.0±0.24ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.22ms     5.1 MB/sec    1.10      8.7±0.39ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.05  1932.2±79.25µs     8.6 MB/sec    1.00  1847.5±51.59µs     9.0 MB/sec
linter/default-rules/numpy/globals.py      1.00    212.0±9.44µs    13.9 MB/sec    1.07    225.8±8.72µs    13.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.0±0.20ms     6.5 MB/sec    1.03      4.1±0.25ms     6.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.6±0.12ms     2.8 MB/sec    1.00     14.6±0.09ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.0±0.04ms     4.2 MB/sec    1.00      4.0±0.04ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    520.1±5.45µs     5.7 MB/sec    1.00   520.0±10.88µs     5.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.6±0.05ms     3.9 MB/sec    1.00      6.5±0.08ms     3.9 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.06ms     5.1 MB/sec    1.03      8.3±0.21ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1779.8±22.65µs     9.4 MB/sec    1.02  1811.9±32.87µs     9.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    196.2±2.94µs    15.0 MB/sec    1.00    196.9±2.54µs    15.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.04ms     6.8 MB/sec    1.01      3.8±0.05ms     6.7 MB/sec

[dhruvmanila]

There are a few cases which I've missed, let me look into them.

[Skylion007]

Thanks for doing, I gave a pass at adding it myself, but I don't have a lot of experience with RustLang or the Ruff codebase.

[dhruvmanila]

• I've updated with separating out the dict and list/set part with a helper function to add a diagnostic.
• The name of the existing function has been changed to unnecessary_list_set_comprehension to better reflect the purpose.
• Add documentation for the rule. Will it be auto-generated for the website?

I'm not sure about the merge strategy used here, so should I rebase and squash relevant commits together?

[charliermarsh]

Great, thanks! Will take a look today.

Add documentation for the rule. Will it be auto-generated for the website?

Yup!

[charliermarsh]

Thanks for this! Sorry, I missed your last question. We almost always squash-and-merge to maintain a 1:1 PR-to-commit equivalence, but GitHub does it for us, so no effort needed on your end.

[dhruvmanila]

Thanks for your feedback and merging! I hope to contribute more as I go deep into Rust and the codebase 😄