Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) #3501

evanrittenhouse · 2023-03-14T03:58:24Z

We ensure that the two arguments to zip() match and that the lower bound of the slice is 1, if the second argument is a slice. Otherwise, we wouldn't be able to guarantee that the request being made is for successive pairs.

andersk

itertools.pairwise is new in Python 3.10, so this rule should be restricted to target_version >= PyVersion::Py310.

Should we also check for zip(a[:-1], a[1:])?

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs

github-actions · 2023-03-15T03:35:05Z

✅ ecosystem check detected no changes.

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs

Also have to change this commit message and finish the stuf laid out in CONTRIBUTING.md

github-actions · 2023-03-16T23:40:54Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.00      9.5±0.27ms     4.3 MB/sec    1.20     11.4±0.38ms     3.6 MB/sec
linter/numpy/ctypeslib.py    1.00      2.4±0.11ms   139.8 MB/sec    1.01      2.4±0.08ms   138.1 MB/sec
linter/numpy/globals.py      1.00  1233.2±44.12µs   144.5 MB/sec    1.00  1235.5±43.22µs   144.3 MB/sec
linter/pydantic/types.py     1.00      4.4±0.17ms     5.8 MB/sec    1.18      5.2±0.16ms     4.9 MB/sec

Windows

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.00      8.7±0.18ms     4.7 MB/sec    1.02      8.9±0.67ms     4.6 MB/sec
linter/numpy/ctypeslib.py    1.04      2.9±0.05ms   116.2 MB/sec    1.00      2.8±0.02ms   121.2 MB/sec
linter/numpy/globals.py      1.03  1510.6±27.55µs   118.0 MB/sec    1.00  1464.6±35.84µs   121.7 MB/sec
linter/pydantic/types.py     1.01      4.1±0.11ms     6.3 MB/sec    1.00      4.0±0.07ms     6.3 MB/sec

charliermarsh · 2023-03-16T23:46:18Z

Should have time to merge this tonight if it's in good shape!

evanrittenhouse · 2023-03-17T00:14:19Z

@charliermarsh just have to get the new changes re-reviewed - I changed the logic for determining successive pairs to simply be a difference of 1 between start of first/second slices. That'll allow us to pick up cases like zip(x[2:], x[3:]) which should still trigger the violation, e.g. pairwise(x[2:]).

charliermarsh · 2023-03-17T03:50:51Z

Thanks @evanrittenhouse!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.256` -> `^0.0.257` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/compatibility-slim/0.0.256)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/confidence-slim/0.0.256)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.257`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.257) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.256...v0.0.257)  #### What's Changed ##### Rules - \[`ruff`] Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3501 - \[`flake8-bugbear`] Add `no-explicit-stacklevel` (`B028`) by [@johnor](https://togithub.com/johnor) in [astral-sh/ruff#3550 - \[`pylint`] invalid-characters-\* by [@r3m0t](https://togithub.com/r3m0t) in [astral-sh/ruff#3552 - \[`pylint`] Implement `useless-return` (`R1711`) by [@tomecki](https://togithub.com/tomecki) in [astral-sh/ruff#3116 - \[`pylint`]: Implement `continue-in-finally` (`E0116`) by [@latonis](https://togithub.com/latonis) in [astral-sh/ruff#3541 ##### Bug Fixes - Rewrite mock import with starred imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3566 - Respect `type` overrides in E721 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3582 - Use `value > max` style in pylint and mccabe messages by [@edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#3553 - Fix autofix conflict between `D209` and `D400` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3564 - Avoid C1901 violations within subscripts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3517 - Avoid adding dashed line outside of docstring by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3581 - Enable ANSI colors on Windows 10 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3583 #### New Contributors - [@johnor](https://togithub.com/johnor) made their first contribution in [astral-sh/ruff#3550 **Full Changelog**: astral-sh/ruff@v0.0.256...v0.0.257 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.256` -> `==0.0.257` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/compatibility-slim/0.0.256)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.257/confidence-slim/0.0.256)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.257`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.257) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.256...v0.0.257)  #### What's Changed ##### Rules - \[`ruff`] Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3501 - \[`flake8-bugbear`] Add `no-explicit-stacklevel` (`B028`) by [@johnor](https://togithub.com/johnor) in [astral-sh/ruff#3550 - \[`pylint`] invalid-characters-\* by [@r3m0t](https://togithub.com/r3m0t) in [astral-sh/ruff#3552 - \[`pylint`] Implement `useless-return` (`R1711`) by [@tomecki](https://togithub.com/tomecki) in [astral-sh/ruff#3116 - \[`pylint`]: Implement `continue-in-finally` (`E0116`) by [@latonis](https://togithub.com/latonis) in [astral-sh/ruff#3541 ##### Bug Fixes - Rewrite mock import with starred imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3566 - Respect `type` overrides in E721 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3582 - Use `value > max` style in pylint and mccabe messages by [@edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#3553 - Fix autofix conflict between `D209` and `D400` by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3564 - Avoid C1901 violations within subscripts by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3517 - Avoid adding dashed line outside of docstring by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3581 - Enable ANSI colors on Windows 10 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3583 #### New Contributors - [@johnor](https://togithub.com/johnor) made their first contribution in [astral-sh/ruff#3550 **Full Changelog**: astral-sh/ruff@v0.0.256...v0.0.257 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

andersk reviewed Mar 14, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs Outdated Show resolved Hide resolved

evanrittenhouse marked this pull request as draft March 14, 2023 04:17

evanrittenhouse force-pushed the 3297_itertools_pairwise branch from 980b098 to e6c51af Compare March 15, 2023 03:18

evanrittenhouse marked this pull request as ready for review March 15, 2023 03:51

MichaReiser reviewed Mar 15, 2023

View reviewed changes

andersk reviewed Mar 15, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs Outdated Show resolved Hide resolved

andersk reviewed Mar 15, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs Outdated Show resolved Hide resolved

MichaReiser approved these changes Mar 16, 2023

View reviewed changes

crates/ruff/src/rules/ruff/rules/pairwise_over_zipped.rs Outdated Show resolved Hide resolved

evanrittenhouse force-pushed the 3297_itertools_pairwise branch from 63001bc to 9a38f44 Compare March 16, 2023 19:44

evanrittenhouse marked this pull request as draft March 16, 2023 19:47

evanrittenhouse added 8 commits March 16, 2023 18:16

Have to implement reviewer feedback

224d82f

Also have to change this commit message and finish the stuf laid out in CONTRIBUTING.md

Add checks for zip(a[:-1], a[1:])

ebecaf4

Add snapshots and such

e65a79d

Formatting

505045b

Elide explicit lifetime

b85a319

Restrict target version to 3.10+

58f81cd

Implement reviewer comments

3923f4d

Add Option<i64> instead of Result. Change successive pair definition

9e9e8fb

evanrittenhouse force-pushed the 3297_itertools_pairwise branch from 9a38f44 to 9e9e8fb Compare March 16, 2023 23:16

Remove Rule pointer

6aba28e

Remove redundant slice_end field

f93f818

evanrittenhouse marked this pull request as ready for review March 17, 2023 00:14

charliermarsh added 2 commits March 16, 2023 23:23

Minor tweaks

96390c2

Avoid steps

ac36c9c

charliermarsh changed the title ~~Prefer itertools.pairwise() over zip() for successive pairs~~ Prefer itertools.pairwise() over zip() for successive pairs (RUF007) Mar 17, 2023

charliermarsh merged commit 33d2457 into astral-sh:main Mar 17, 2023
12 checks passed

charliermarsh added the rule Implementing or modifying a lint rule label Mar 17, 2023

evanrittenhouse deleted the 3297_itertools_pairwise branch March 17, 2023 13:42

mikelane mentioned this pull request Mar 20, 2023

Bump ruff from 0.0.256 to 0.0.257 in /{{ cookiecutter.__project_name }} mikelane/cookiecutter-python-library#4

Closed

MaxWinterstein mentioned this pull request Mar 21, 2023

RUF007 - False positive when zip() contains more than 2 arguments #3651

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) #3501

Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) #3501

evanrittenhouse commented Mar 14, 2023

andersk left a comment

github-actions bot commented Mar 15, 2023 •

edited

github-actions bot commented Mar 16, 2023 •

edited

charliermarsh commented Mar 16, 2023

evanrittenhouse commented Mar 17, 2023

charliermarsh commented Mar 17, 2023

Prefer itertools.pairwise() over zip() for successive pairs (RUF007) #3501

Prefer itertools.pairwise() over zip() for successive pairs (RUF007) #3501

Conversation

evanrittenhouse commented Mar 14, 2023

andersk left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 15, 2023 • edited

github-actions bot commented Mar 16, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh commented Mar 16, 2023

evanrittenhouse commented Mar 17, 2023

charliermarsh commented Mar 17, 2023

Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) #3501

Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) #3501

github-actions bot commented Mar 15, 2023 •

edited

github-actions bot commented Mar 16, 2023 •

edited