Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! Support mutually exclusive branches for B031 (#3844) #3875

Merged
merged 1 commit into from Apr 4, 2023

Conversation

dhruvmanila
Copy link
Member

I'm not sure why I added that condition, but nevertheless here's the fixup for that 🤔

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     14.1±0.04ms     2.9 MB/sec    1.00     14.0±0.04ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.7 MB/sec    1.00      3.5±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    455.2±1.46µs     6.5 MB/sec    1.00    453.7±0.91µs     6.5 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.1±0.12ms     4.2 MB/sec    1.00      6.0±0.03ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.02      7.3±0.08ms     5.6 MB/sec    1.00      7.1±0.02ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1615.6±1.50µs    10.3 MB/sec    1.00  1615.9±10.30µs    10.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    178.4±0.40µs    16.5 MB/sec    1.01    179.9±0.63µs    16.4 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.3±0.00ms     7.7 MB/sec    1.00      3.3±0.01ms     7.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.02     17.3±0.36ms     2.4 MB/sec    1.00     16.9±0.23ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      4.5±0.16ms     3.7 MB/sec    1.00      4.4±0.09ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.01   515.8±16.09µs     5.7 MB/sec    1.00   511.5±23.28µs     5.8 MB/sec
linter/all-rules/pydantic/types.py         1.04      7.4±0.18ms     3.4 MB/sec    1.00      7.2±0.14ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.7±0.11ms     4.7 MB/sec    1.01      8.7±0.19ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1879.8±30.44µs     8.9 MB/sec    1.00  1888.7±35.41µs     8.8 MB/sec
linter/default-rules/numpy/globals.py      1.03    206.9±8.39µs    14.3 MB/sec    1.00    200.0±8.16µs    14.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.9±0.05ms     6.5 MB/sec    1.01      4.0±0.08ms     6.4 MB/sec

@charliermarsh charliermarsh merged commit 2b21eff into astral-sh:main Apr 4, 2023
13 checks passed
@dhruvmanila dhruvmanila deleted the fixup/76e111c8 branch April 4, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants