Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out common exemption-parsing logic #3670

Merged
merged 1 commit into from Mar 22, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

This is a non-behavior-changing refactor that I initially pursued as part of #3665. I ended up using a different solution for that PR, but this feels like an improvement anyway.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Mar 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.2±0.04ms     2.9 MB/sec    1.01     14.3±0.05ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.8±0.01ms     4.4 MB/sec    1.01      3.8±0.01ms     4.4 MB/sec
linter/all-rules/numpy/globals.py          1.01    437.3±1.59µs     6.7 MB/sec    1.00    432.6±1.56µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.3±0.01ms     4.1 MB/sec    1.01      6.3±0.01ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.00      7.8±0.01ms     5.2 MB/sec    1.00      7.8±0.01ms     5.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1716.3±3.82µs     9.7 MB/sec    1.00   1717.2±4.05µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    176.7±0.30µs    16.7 MB/sec    1.00    176.9±0.96µs    16.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.01ms     7.0 MB/sec    1.00      3.7±0.01ms     7.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.3±0.23ms     2.5 MB/sec    1.01     16.4±0.22ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.4±0.11ms     3.8 MB/sec    1.01      4.4±0.15ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.00   546.7±10.34µs     5.4 MB/sec    1.02   556.1±13.73µs     5.3 MB/sec
linter/all-rules/pydantic/types.py         1.01      7.3±0.10ms     3.5 MB/sec    1.00      7.2±0.10ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.00      8.6±0.12ms     4.7 MB/sec    1.01      8.7±0.11ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1881.1±19.00µs     8.9 MB/sec    1.01  1893.7±18.37µs     8.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    204.5±6.79µs    14.4 MB/sec    1.01    206.3±6.69µs    14.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.0±0.10ms     6.3 MB/sec    1.00      4.0±0.07ms     6.4 MB/sec

@charliermarsh charliermarsh merged commit 07808a5 into main Mar 22, 2023
13 checks passed
@charliermarsh charliermarsh deleted the charlie/exemption branch March 22, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant