Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move scope and binding types to scope.rs #3573

Merged
merged 2 commits into from Mar 17, 2023
Merged

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Mar 17, 2023

This PR moves all the scope/binding related types out of context.rs and types.rs into scope.rs

@MichaReiser
Copy link
Member Author

MichaReiser commented Mar 17, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.01      7.8±0.03ms     5.2 MB/sec    1.00      7.7±0.02ms     5.3 MB/sec
linter/numpy/ctypeslib.py    1.00      2.4±0.00ms   144.9 MB/sec    1.09      2.6±0.01ms   133.4 MB/sec
linter/numpy/globals.py      1.00   1208.7±3.29µs   147.5 MB/sec    1.07   1299.3±5.08µs   137.2 MB/sec
linter/pydantic/types.py     1.01      3.6±0.01ms     7.0 MB/sec    1.00      3.6±0.01ms     7.1 MB/sec

Windows

group                        main                                   pr
-----                        ----                                   --
linter/large/dataset.py      1.01      8.9±0.04ms     4.6 MB/sec    1.00      8.8±0.04ms     4.6 MB/sec
linter/numpy/ctypeslib.py    1.02      2.3±0.01ms   147.5 MB/sec    1.00      2.2±0.01ms   150.0 MB/sec
linter/numpy/globals.py      1.02   1178.9±5.16µs   151.2 MB/sec    1.00  1154.2±13.80µs   154.4 MB/sec
linter/pydantic/types.py     1.00      4.1±0.03ms     6.3 MB/sec    1.00      4.1±0.07ms     6.2 MB/sec

Base automatically changed from scope-banding-id to main March 17, 2023 16:12
@MichaReiser MichaReiser merged commit dedf4cb into main Mar 17, 2023
12 checks passed
@MichaReiser MichaReiser deleted the extract-scope branch March 17, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants