fix: NPX apply changelog (npx @changesets/cli version) #1562

Netail · 2025-01-20T22:39:39Z

#1500, but a bit simpler

fixes: #566
fixes: #1426

If you would like to test it yourself;
npx @netail/changeset-cli@2.27.15 version

codecov · 2025-01-20T22:40:50Z

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (a8c474f) to head (3e44749).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/apply-release-plan/src/index.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   81.02%   81.00%   -0.02%     
==========================================
  Files          54       54              
  Lines        2229     2232       +3     
  Branches      662      663       +1     
==========================================
+ Hits         1806     1808       +2     
- Misses        419      420       +1     
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

changeset-bot · 2025-01-20T22:42:57Z

🦋 Changeset detected

Latest commit: 3e44749

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@changesets/apply-release-plan	Patch
@changesets/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Fixes #566

.changeset/warm-results-rescue.md

Andarist · 2025-01-21T14:26:57Z

packages/apply-release-plan/src/index.ts

+    changelogPath = resolveFrom(changesetPath, config.changelog[0]);
+  } catch {
+    changelogPath = resolveFrom(
+      path.join(__dirname, "..", ".."),


I understand what you are doing here but I don't think we should just blindly~ escape the current directory like this in hope to end up in the correct directory. This alternative cwd should be passed down as part of the options to this function

~~resolveForm does not seem to accept options.~~

But isn't cwd the issue here as NPX installs the npm package into a npm cache folder somewhere in the home directory or %localappdata% for windows, while the process itself gets executed in a workspace (potentially) far from this cache directory. Resulting in changeset searching in the local node_modules where the process is executed, while it should search in the npm-cache (close to where the changeset/cli cache is located)

Packages located here: ~/.npm/_npx/<hash>/node_modules/@changesets/cli ~/.npm/_npx/<hash>/node_modules/@changesets/apply-release-plan ~/.npm/_npx/<hash>/node_modules/@changesets/git Executed here: ~/Documents/React/<project> __dirname: ~/npm/<hash>/node_modules/@changesets/apply-release-plan/index.js cwd: ~/Documents/React/<project>

Never mind, I get what you mean. Applied & testing, seems to work :)

Andarist · 2025-01-22T11:09:25Z

packages/apply-release-plan/src/index.ts

+  try {
+    changelogPath = resolveFrom(changesetPath, config.changelog[0]);
+  } catch {
+    changelogPath = resolveFrom(__dirname, config.changelog[0]);


This is better but this "context dir" should come from options. I feel like we want to resolve this in the context of the executed @changesets/cli and not in the context of @changesets/apply-release-plan, even if that ends up resolving to the same location in the majority of cases.

Something like 3c786a6 you mean?

Yep, this version works for me 👍 Have you tried testing the current state of this PR in "the real world"?

Haven't yet since 3c786a6 (Since the __dirname coming from the cli package), before that I did. https://www.npmjs.com/package/@netail/changeset-cli + underlying https://www.npmjs.com/package/@netail/changesets-apply-release-plan

I can check the latest changes tonight

I can check the latest changes tonight

I'd appreciate it 👍

Alright, seems to work

ref npx @netail/changeset-cli@2.27.21 version (https://www.npmjs.com/package/@netail/changeset-cli)

packages/apply-release-plan/src/index.ts

.changeset/warm-results-rescue.md

…1562) * Resolve module from global node_modules Fixes changesets#566 * fix: NPX apply changelog * fix: feedback * fix: feedback v2 * fix: feedback v3 * Create seven-beans-jump.md * Apply suggestions from code review --------- Co-authored-by: Cefn Hoile <github.com@cefn.com> Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Netail mentioned this pull request Jan 20, 2025

Allow @changesets/cli/changelog to be resolved even when homed in global node_modules #1500

Closed

Resolve module from global node_modules

f217ccb

Fixes #566

Netail force-pushed the fix/npx-apply-changelog branch from 8655d94 to b8f393c Compare January 21, 2025 14:18

fix: NPX apply changelog

Loading
Loading status checks…

865f492

Netail force-pushed the fix/npx-apply-changelog branch from b8f393c to 865f492 Compare January 21, 2025 14:20

Andarist reviewed Jan 21, 2025

View reviewed changes

.changeset/warm-results-rescue.md Outdated Show resolved Hide resolved

Andarist reviewed Jan 21, 2025

View reviewed changes

.changeset/warm-results-rescue.md Show resolved Hide resolved

Andarist reviewed Jan 21, 2025

View reviewed changes

fix: feedback

Verified

This commit was signed with the committer’s verified signature.

mgaffney Michael Gaffney

GPG key ID: 21FE4844A1193A56

Verified
Learn about vigilant mode

Loading
Loading status checks…

cf4c8e4

Netail force-pushed the fix/npx-apply-changelog branch from 0e25c14 to cf4c8e4 Compare January 21, 2025 22:23

Andarist reviewed Jan 22, 2025

View reviewed changes

fix: feedback v2

Verified

This commit was signed with the committer’s verified signature.

paskal Dmitry V

SSH Key Fingerprint: NEVmTk6gELn1W26Ch0ssmI91BqiKIN5JjTmntBx98mc
Verified
Learn about vigilant mode

Loading
Loading status checks…

3c786a6

Netail force-pushed the fix/npx-apply-changelog branch from a66d857 to 3c786a6 Compare January 22, 2025 11:17

Andarist reviewed Jan 22, 2025

View reviewed changes

packages/apply-release-plan/src/index.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 22, 2025

View reviewed changes

packages/apply-release-plan/src/index.ts Outdated Show resolved Hide resolved

Netail and others added 2 commits January 22, 2025 13:49

fix: feedback v3

Verified

This commit was signed with the committer’s verified signature.

paskal Dmitry V

SSH Key Fingerprint: NEVmTk6gELn1W26Ch0ssmI91BqiKIN5JjTmntBx98mc
Verified
Learn about vigilant mode

Loading
Loading status checks…

6a4a8bf

Create seven-beans-jump.md

Verified

This commit was signed with the committer’s verified signature.

paskal Dmitry V

SSH Key Fingerprint: NEVmTk6gELn1W26Ch0ssmI91BqiKIN5JjTmntBx98mc
Verified
Learn about vigilant mode

Loading
Loading status checks…

3cadb74

Andarist reviewed Jan 24, 2025

View reviewed changes

.changeset/warm-results-rescue.md Outdated Show resolved Hide resolved

Andarist reviewed Jan 24, 2025

View reviewed changes

.changeset/warm-results-rescue.md Outdated Show resolved Hide resolved

Apply suggestions from code review

Verified

This commit was signed with the committer’s verified signature.

paskal Dmitry V

SSH Key Fingerprint: NEVmTk6gELn1W26Ch0ssmI91BqiKIN5JjTmntBx98mc
Verified
Learn about vigilant mode

Loading
Loading status checks…

3e44749

Andarist merged commit a0f87f1 into changesets:main Jan 24, 2025
3 checks passed

github-actions bot mentioned this pull request Jan 24, 2025

Version Packages #1567

Merged

Netail deleted the fix/npx-apply-changelog branch January 24, 2025 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: NPX apply changelog (npx @changesets/cli version) #1562

fix: NPX apply changelog (npx @changesets/cli version) #1562

Netail commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading

changeset-bot bot commented Jan 20, 2025 •

edited

Loading

Andarist Jan 21, 2025

Netail Jan 21, 2025 •

edited

Loading

Netail Jan 21, 2025 •

edited

Loading

Andarist Jan 22, 2025

Netail Jan 22, 2025

Andarist Jan 22, 2025

Netail Jan 22, 2025 •

edited

Loading

Andarist Jan 22, 2025

Netail Jan 22, 2025 •

edited

Loading

fix: NPX apply changelog (npx @changesets/cli version) #1562

fix: NPX apply changelog (npx @changesets/cli version) #1562

Conversation

Netail commented Jan 20, 2025 • edited Loading

codecov bot commented Jan 20, 2025 • edited Loading

Codecov Report

changeset-bot bot commented Jan 20, 2025 • edited Loading

🦋 Changeset detected

Andarist Jan 21, 2025

Choose a reason for hiding this comment

Netail Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

Netail Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

Andarist Jan 22, 2025

Choose a reason for hiding this comment

Netail Jan 22, 2025

Choose a reason for hiding this comment

Andarist Jan 22, 2025

Choose a reason for hiding this comment

Netail Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Andarist Jan 22, 2025

Choose a reason for hiding this comment

Netail Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Netail commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading

changeset-bot bot commented Jan 20, 2025 •

edited

Loading

Netail Jan 21, 2025 •

edited

Loading

Netail Jan 21, 2025 •

edited

Loading

Netail Jan 22, 2025 •

edited

Loading

Netail Jan 22, 2025 •

edited

Loading