Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert comments in "legal comments" format to jsdoc or normal comments #1598

Merged
merged 1 commit into from Feb 1, 2024

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented Feb 1, 2024

These are preserved by default in some bundlers (not sure why you'd bundle chai but 馃し馃徎 ). Figured this was more correct than not.

See https://esbuild.github.io/api/#legal-comments

Fixes #1425

@koddsson koddsson requested a review from a team as a code owner February 1, 2024 06:50
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, may be interesting to know if there was originally any reason behind this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad comments in chai.js (and elsewhere)
3 participants