Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殤 Fix FormData encoding (#1741) #1747

Merged
merged 2 commits into from
Mar 17, 2023
Merged

馃殤 Fix FormData encoding (#1741) #1747

merged 2 commits into from
Mar 17, 2023

Conversation

kuhnroyal
Copy link
Member

@kuhnroyal kuhnroyal commented Mar 17, 2023 •
edited

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Fixes #1741

@kuhnroyal kuhnroyal self-assigned this Mar 17, 2023
@kuhnroyal kuhnroyal requested a review from a team as a code owner March 17, 2023 14:42
AlexV525
AlexV525 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment suggestion

dio/lib/src/utils.dart Show resolved Hide resolved
@AlexV525
Copy link
Member

After merging this, you can comment with a new version in the release comment to publish the fix ASAP.

@kuhnroyal kuhnroyal merged commit f9c923b into cfug:main Mar 17, 2023
@kuhnroyal kuhnroyal deleted the fix/form_data_encoding branch March 17, 2023 18:49
@katjai1 katjai1 mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees

@kuhnroyal kuhnroyal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormData.fromMap is encoding request body automatically
2 participants
@kuhnroyal @AlexV525