Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Allow to parse Set-Cookie with redirected response #1734

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Mar 12, 2023

Fix #1715.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

When using followRedirects there's no way to handle the cookie value, and Set-Cookie won't be passed through the redirection. This also happened with the http library, the cookie is not available for redirections if Set-Cookie happen during redirects.

@AlexV525 AlexV525 marked this pull request as ready for review March 12, 2023 16:48
@AlexV525 AlexV525 requested a review from a team as a code owner March 12, 2023 16:48
Copy link
Member

@talisk talisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A code indentation mistake in README.

@AlexV525 AlexV525 changed the title 🐛 Use Response.realUri when saving cookies 🐛 Allow to parse Set-Cookie with redirected response Mar 14, 2023
@AlexV525 AlexV525 merged commit 8cc1358 into main Mar 16, 2023
@AlexV525 AlexV525 deleted the save-cookies-for-response-read-uri branch March 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic redirection does not trigger the interceptor, causing the cookieJar interceptor to not work properly
2 participants