Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up permissions to github workflows #218

Merged
merged 2 commits into from Feb 24, 2023
Merged

Set up permissions to github workflows #218

merged 2 commits into from Feb 24, 2023

Conversation

joycebrum
Copy link
Contributor

Changes

  • set top level permission as contents: read to ci.yml. It seems to work with only a warn regarding python3.6 not giving support to attr: https://github.com/joycebrum/python-certifi/actions/runs/4256060098
  • grant issues: write only to the job with no permissions in top-level. No permission has actually changed (it was only issues: write by the start) but any other job added to the workflow will have no permission by default. I can change it to contents: read if you rather.

Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but would you mind rebasing on main to pick up a fix for teh tests?

Signed-off-by: Joyce <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
@joycebrum
Copy link
Contributor Author

Done @alex and the action is working after the fix! https://github.com/joycebrum/python-certifi/actions/runs/4263462128

@alex alex merged commit c211ef4 into certifi:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants