update dependencies #9893
update dependencies #9893
Conversation
|
Happy to accept these changes, but out of curiosity why was libssl upgraded in the first test but not anymore? Or was that what was breaking, and not the alpine 3.18 vs 3.19? |
|
libssl was what was breaking things I believe. alpine 3.18 and 3.19 are both still supported, but 3.19 only has openssl 3.0+. alpine 3.18 still has openssl 1.1 and after downgrading to 3.18 and that version of openssl, cryptography actually manages to build. |
|
to clarify, I suspect it was the libssl change, but I don't actually know that. either change could have fixed things. all I know is this one seems to work and the other one hung for 3 hours with no significant output |
|
Works for me, though we should probably actually do that upgrade and get dependencies in order at some point, probably worth making an issue to track that. |
|
kk. I created #9894. |
Fixes #9892 and https://github.com/certbot/certbot/security/dependabot
Upgrading the base docker image has been done in previous PRs like #9415. Doing this was needed because the newer versions of
cryptographyneed a newer version of rust.I ran the full test suite on this branch which you can see in the GitHub status checks below. The boulder tests should fail as they're to be fixed by #9889 but everything else should pass.