Docs: Reset requirements.txt path #9877
Conversation
zoracon
changed the title
zoracon
requested review from
a team,
wgreenberg and
bmw
and removed request for
a team and
wgreenberg
|
Seeing that there is a way to test with the branches. I am assuming someone adjusted to see that. So putting merging on hold until I resolve the error. |
There was a problem hiding this comment.
Progress! Using the same process to test this that I described here, I got this build. Now it properly finds the file, but it fails to install everything in it because this file contains ALL possible Python dependencies of ours and readthedocs is missing non-Python dependencies like Augeas our project links to.
To suggest a possible path forward, I'd maybe use our requirements file as constraints for pip and then configure readthedocs to only install the parts of our code it needs. This is the kind of setup we had before in files like https://github.com/certbot/certbot/blob/7ca1b8f2867b252f8657b49a3fb4c374670a629d/certbot-dns-cloudflare/readthedocs.org.requirements.txt before readthedocs decided it no longer wanted to support it 🙁 I found an example of this kind of configuration with the new yaml files at readthedocs/readthedocs.org#7258 (comment) although I think it may work to just use these existing "readthedocs.org.requirements.txt" files as the requirements in each respective yaml file.
I think it's up to you if you'd like to merge this as a correct, incremental improvement or continue iterating on this here.
- Will amend copyright parameter at a later date
|
@bmw Okay I redirected to the requirements.txt and have passing builds. |
Readthedocs does not like relative paths. I believe it can just read down from the root of the repo (hopefully). There's no clear way to test this locally.