Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps cert-manager lib in cmctl #6105

Merged
merged 1 commit into from
May 25, 2023
Merged

Bumps cert-manager lib in cmctl #6105

merged 1 commit into from
May 25, 2023

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented May 25, 2023 •
edited

Pull Request Motivation

Bumps cert-manager version in cmctl's go.mod (cd cmd/ctl && go get github.com/cert-manager/cert-manager@7ea113504de21e2b9b65718bd2f86ee59980494b)

I did this the wrong way round as I have already pushed the 1.12.1 tag.

I've also corrected the release flow wrt this in cert-manager/website#1234

Release Note

NONE

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@irbekrm
Bump cert-manager in cmctl to latest 1.12 commit
a4c1c54 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Copy link
Contributor Author

irbekrm commented May 25, 2023

/retest

SgtCoDFish
SgtCoDFish approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 😁

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 3f5dbe1 into cert-manager:release-1.12 May 25, 2023
7 checks passed
@jetstack-bot jetstack-bot mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irbekrm @jetstack-bot @SgtCoDFish