Added as_uri method to MongoDB transport - Fixes #1795 #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanukes
changed the title
auvipy
requested changes
Sep 23, 2023
|
Done! I ran the unit tests locally |
auvipy
approved these changes
Sep 26, 2023
|
@auvipy do you mind if I add more changes to MongoDB transport? I found an issue when a particular URI was not parsed correctly. And there's an easy fix. Let me know if you prefer another PR |
|
Another PR for another bug is highly welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1795.
Added as_uri method to MongoDB transport, now the Replica Set URIs parse correctly.