Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try possible fix to avoid a oracle regression #325

Merged
merged 1 commit into from
Jun 29, 2022
Merged

try possible fix to avoid a oracle regression #325

merged 1 commit into from
Jun 29, 2022

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Jun 29, 2022

suggested fix for #308

auvipy referenced this pull request Jun 29, 2022
When upgrading from <2.0.0 while current chords are not finished, the ChordCounter object does not exist, breaking the chord.
The `celery.chord_unlock` Task created by the legacy chord should unlock any existing chord while new chord will create the proper ChordCounter object
@auvipy auvipy marked this pull request as ready for review June 29, 2022 13:05
Copy link
Contributor

@AllexVeldman AllexVeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as is

@auvipy auvipy merged commit 6dd69e5 into master Jun 29, 2022
@auvipy auvipy deleted the bug308 branch June 29, 2022 13:26
Copy link

@zenoran zenoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to retain the functionality needed by the previous change, as well as not break for Oracle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants