Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ streamline makeTwoQubitGateDD method #572

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

burgholzer
Copy link
Member

Description

The second follow-up PRs to #358, which tries to simplify the underlying functions and methods for representing operations.
This PR specifically streamlines the makeTwoQubitGateDD method in the DD package and eliminates the nqubits and start parameters, which are no longer necessary.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added enhancement New feature or request refactor Anything related to code refactoring DD Anything related to the DD package c++ Anything related to C++ code labels Mar 25, 2024
@burgholzer burgholzer added this to the DD Package Improvements milestone Mar 25, 2024
@burgholzer burgholzer self-assigned this Mar 25, 2024
Base automatically changed from streamline-make-gate-dd to main March 25, 2024 17:36
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the streamline-make-two-qubit-gate-dd branch from 0324e77 to 2562d24 Compare March 26, 2024 08:21
@burgholzer burgholzer enabled auto-merge (squash) March 26, 2024 08:24
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.2%. Comparing base (e419f69) to head (2562d24).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #572   +/-   ##
=====================================
  Coverage   91.2%   91.2%           
=====================================
  Files        132     132           
  Lines      13989   13978   -11     
  Branches    2225    2216    -9     
=====================================
- Hits       12766   12760    -6     
+ Misses      1223    1218    -5     
Flag Coverage Δ
cpp 90.9% <100.0%> (+<0.1%) ⬆️
python 99.5% <ø> (ø)
Files Coverage Δ
include/mqt-core/dd/Operations.hpp 88.2% <100.0%> (-0.2%) ⬇️
include/mqt-core/dd/Package.hpp 97.6% <100.0%> (+0.4%) ⬆️

... and 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 16ae2b7 into main Mar 26, 2024
37 checks passed
@burgholzer burgholzer deleted the streamline-make-two-qubit-gate-dd branch March 26, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package enhancement New feature or request refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant