Fix: AfterGroups config annotation does not consider retries for tests #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krmahadevan
reviewed
Dec 11, 2021
testng-core/src/test/java/test/retryAnalyzer/issue2684/IssueTest.java
Outdated
Show resolved
Hide resolved
krmahadevan
requested changes
Dec 11, 2021
|
@krmahadevan This bug affects only @AfterGroups, should I add checks for other config methods to the test too? |
|
Yes pls. That way we will be sure that we have covered all aspects in terms of tests for retry analyser + config method combos. |
|
@krmahadevan done |
juherr
approved these changes
Dec 11, 2021
|
@morskyrv Thank you for taking the time to help raise a PR. Hope to see many more from you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #2684 but I'm not sure about this solution, so waiting for comments.
Fixes #2684.
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.