Yaml parser: implement loadClasses flag #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsankouski
force-pushed
the
implement_yaml_load_classes_flag
branch
2 times, most recently
from
6667b8c
to
e0701da
Compare
Parser loadClasses flag controls, whether test classes will be loaded during suite parsing. Setting it to false allow to load yaml suite with non-existent classes, whereas true will fail parsing on test class loading.
dsankouski
force-pushed
the
implement_yaml_load_classes_flag
branch
from
e0701da
to
a1f2e3f
Compare
krmahadevan
reviewed
Dec 6, 2021
| } else { | ||
| className = ((ScalarNode) node).getValue(); | ||
| } | ||
| return c.newInstance(className, loadClasses); |
There was a problem hiding this comment.
Can we please use org.testng.internal.objects.InstanceCreator#newInstance(java.lang.reflect.Constructor<T>, java.lang.Object...) to create the instance ?
krmahadevan
reviewed
Dec 6, 2021
| nodeTuple -> | ||
| ((ScalarNode) nodeTuple.getKeyNode()).getValue().equals("name")) | ||
| .findFirst() | ||
| .orElseThrow(RuntimeException::new) |
There was a problem hiding this comment.
Can we consider throwing org.testng.TestNGException instead with a proper error message that explains what went wrong ?
krmahadevan
reviewed
Dec 6, 2021
CHANGES.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| Current | |||
| New: Yaml parser: implement loadClasses flag (Dzmitry Sankouski) | |||
There was a problem hiding this comment.
Just for traceability, it would be good if you could please help do the following:
- Log a bug that explains the problem
- Refer to that bug id here so that the changeset information is available in the
CHANGES.txt - Add a reference to the issue in the
descriptionattribute of@Testtest, so that we know that the test belongs to a specific defect.
|
closes #2689 |
- use InstanceCreator#newInstance() - use TestNG exception with detail exception message - create and link github issue
krmahadevan
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
@juherr - Can you please help take a quick look from your side as well ?
juherr
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser loadClasses flag controls, whether test classes will be loaded during
suite parsing. Setting it to false allow to load yaml suite with non-existent
classes, whereas true will fail parsing on test class loading.
Did you remember to?
CHANGES.txt./gradlew autostyleApply