Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update supported Python and Django versions #1643

Conversation

adamantike
Copy link
Contributor

Minimal Django version is now 4.2 (oldest supported version upstream [1]) Minimal Python version is now 3.8 (oldest Python version supported by Django 4.2)

[1] https://www.djangoproject.com/download/#supported-versions

Minimal Django version is now 4.2 (oldest supported version upstream [1])
Minimal Python version is now 3.8 (oldest Python version supported by
Django 4.2)

[1] https://www.djangoproject.com/download/#supported-versions
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (a2f7aba) to head (25a8310).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   98.59%   98.51%   -0.09%     
==========================================
  Files          15       15              
  Lines        1285     1280       -5     
==========================================
- Hits         1267     1261       -6     
- Misses         18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tox.ini Outdated
{py38,py39}-{django40,django41,django42},
{py310, py311}-{django41,django42,latest},
{py310, py311, py312}-{django41,django42,django50,latest},
{py38,py39,py310}-django32,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop django32 too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I also found some combinations were duplicated (e.g. Python 3.11 / Django 4.2), so moved it to a line per Django version.

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just the one comment.

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@carltongibson carltongibson merged commit 1808e21 into carltongibson:main Mar 8, 2024
8 checks passed
@adamantike adamantike deleted the feat/remove-deprecated-django-versions branch March 8, 2024 15:24
@carltongibson
Copy link
Owner

Thanks @adamantike — I'll roll a release over the weekend.

@carltongibson
Copy link
Owner

Turned out that was this afternoon https://pypi.org/project/django-filter/24.1/

@adamantike
Copy link
Contributor Author

Thank you for the quick release! I can confirm the unneeded django.test import time reported in #1641 is now gone.

image

@carltongibson
Copy link
Owner

Lovely. Thanks for the report and PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants