Fixed OrderingFilter handling of empty values. #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A trailing comma would cause a crash trying to map an empty value to a field name. Ensure sub-values are filtered for EMPTY_VALUES in addition to the main filter data. Closes #1597. Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
carltongibson
force-pushed
the
pr/1598-alt
branch
from
2220231
to
acc50a2
Compare
|
Thanks for taking a look @carltongibson! I can confirm this works for me. |
|
Works for me as well, thanks a bunch @carltongibson! |
|
Thanks both! Version 23.5 is available on PyPI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trailing comma would cause a crash trying to map an empty value to a field name. Ensure sub-values are filtered for EMPTY_VALUES in addition to the main filter data.
Closes #1597.
Hi @munnsmunns, @scott-8. Sorry for the slow uptake: it was a while getting the bandwidth.
Here's an alternate take on #1598.
The behaviour of
CSVWidgetto map","to["",""]is covered by regression tests, soOrderingFilterneeds to filter these prior to filtering. The natural place for such is in thefiltermethod, where the empty check occurs for all filters.If you have the space, could you give it a run and let me know if it works for you? Thanks.