Don't cause RemovedInDjango50Warning in handle_timezone with Django 4.2. #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes carltongibson#1580. Unless USE_DEPRECATED_PYTZ is present and True, we should not be passing the is_dst parameter.
Codecov Report
@@ Coverage Diff @@
## main #1581 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 15 15
Lines 1271 1271
=======================================
Hits 1253 1253
Misses 18 18
|
carltongibson
approved these changes
May 23, 2023
There was a problem hiding this comment.
OK, thanks @lewiscollard — let's have this.
Whilst you're in here, if you fancied looking at bb7198d and having a think about whether the skipped tests there can be updated (or simply dropped at some point) that would be cool. (I didn't have mental space for it at the time, I do admit.)
Welcome aboard! ⛵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580.
Unless
USE_DEPRECATED_PYTZis present and True, we should not be passing theis_dstargument.