Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.1 introduced a backwards incompatible change that is not listed in the changelog #1511

Merged
merged 1 commit into from Mar 26, 2023

Conversation

lociii
Copy link
Contributor

@lociii lociii commented Jul 6, 2022

Release 22.1 removed compatibility fallbacks that were originally scheduled to be removed in release 2.1

  • filter_class could still be used instead of filterset_class
  • filter_fields could still be used instead of filterset_fields

Both were mentioned in the 2.0 migration guide but then forgotten to be removed in 2.1.

IMHO this should be mentioned in the changelog as someone (e.g. me 馃ゲ) might still have used them.

Thanks

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

These have been issuing deprecation warnings for several years now...

@carltongibson
Copy link
Owner

C.I. is broken pending encode/django-rest-framework#8543

Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #1511 (5ad0e22) into main (de3019c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          15       15           
  Lines        1258     1258           
=======================================
  Hits         1251     1251           
  Misses          7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@carltongibson carltongibson merged commit ccf9582 into carltongibson:main Mar 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants