Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ibm-common): add mandatory IBM instrumentation tags (v2) #11929

Merged
merged 5 commits into from
Jul 19, 2024
Merged

chore(ibm-common): add mandatory IBM instrumentation tags (v2) #11929

merged 5 commits into from
Jul 19, 2024
+112 −8

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

Adding mandatory intrumentation tags for Carbon for IBM.com web components storybook

Changelog

Changed

  • Added ibm-common.js and IBM footer to storybooks

ibmdotcom-bot and others added 4 commits July 11, 2024 19:55
@ibmdotcom-bot
Merge 168853b into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
2c59881
@ibmdotcom-bot
Merge 83739d4 into main
Loading
Loading status checks…
ff7aa9e
@jeffchew
chore(ibm-common): add mandatory IBM instrumentation tags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
04ffe74
@jeffchew
chore(ibm-common): fix positioning of footer
Loading
Loading status checks…
dcbc4ea
@jeffchew jeffchew requested a review from a team as a code owner July 16, 2024 17:21
@jeffchew jeffchew requested review from kennylam and annawen1 and removed request for a team July 16, 2024 17:21
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 16, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11929/index.html

Built with commit: 609afdc9857a529cb680f3fdfcc9d45f3ad12917

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 16, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11929/index.html

Built with commit: 609afdc9857a529cb680f3fdfcc9d45f3ad12917

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 16, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11929/index.html

Built with commit: 609afdc9857a529cb680f3fdfcc9d45f3ad12917

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 16, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11929/index.html

Built with commit: 609afdc9857a529cb680f3fdfcc9d45f3ad12917

@annawen1 annawen1 changed the base branch from main to release/v2.11.0 July 17, 2024 13:16
@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Jul 18, 2024
@annawen1 annawen1 merged commit b5e00a5 into carbon-design-system:release/v2.11.0 Jul 19, 2024
12 of 21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1

@kennylam kennylam

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffchew @ibmdotcom-bot @annawen1