feat: [#1724] Add prefers-reduced-motion support #1725
Merged
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is modeled after previous work done for `prefers-color-scheme`. Like `prefers-color-scheme`, I've added this as a device setting that can be a string, one of "no-preference" (the default) or "reduce".
capricorn86
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thank you for your contribution @mwdiaz! ⭐
I pushed in a fix to check if settings exist as it can potentially be null during tear down. It seems like it was missed before as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1724, this is an implementation we're using locally via
pnpm patchand it's been working well. I modeled the change after work done previously in #354, so hopefully I'm not too off base. I did consider making theprefersReducedMotionsetting a boolean, but I think it makes more sense to accept the valid string values for the setting, which is also more future proof if they ever decide to extend the spec to accept more values.Thanks for all the work on this project!