Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1221@minor: Add support for :target pseudo selector. #1235

Merged
merged 4 commits into from Feb 26, 2024
Merged

#1221@minor: Add support for :target pseudo selector. #1235

merged 4 commits into from Feb 26, 2024

Conversation

Schleuse
Copy link
Contributor

@Schleuse Schleuse commented Jan 24, 2024 •
edited

Fixes #1221 and implements :target pseudo selector.

@Schleuse Schleuse force-pushed the task/1221-add-support-for-target-and-target-within branch from ce0eb5a to 6c3dcbe Compare January 24, 2024 14:57
@Schleuse Schleuse force-pushed the task/1221-add-support-for-target-and-target-within branch from 6c3dcbe to 47aa46b Compare January 24, 2024 14:58
@Schleuse Schleuse changed the title #1221@minor: Add support for :target and :target-within pseudo selector. Draft: #1221@minor: Add support for :target and :target-within pseudo selector. Jan 25, 2024
@Schleuse
Copy link
Contributor Author

I've noticed that the :target-within implementation only checks direct children - I've marked the PR as draft and I will take a look again 😅

@Schleuse Schleuse force-pushed the task/1221-add-support-for-target-and-target-within branch from 75d773f to 47aa46b Compare January 25, 2024 15:51
@Schleuse Schleuse changed the title Draft: #1221@minor: Add support for :target and :target-within pseudo selector. #1221@minor: Add support for :target pseudo selector. Jan 25, 2024
@Schleuse
Copy link
Contributor Author

As :target-within seems to be still very experimental in Browsers I've opted to remove the support for it

capricorn86
capricorn86 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Schleuse! 🌟

@capricorn86 capricorn86 merged commit efb48f0 into capricorn86:master Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for :target pseudo-selector
2 participants
@Schleuse @capricorn86