#1223@patch: Relax MutationObserver.observe check for options argument.
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bserve options validation failure.
…options` argument. Throw `TypeError` instead of `DOMException` when validation fails.
romansp
force-pushed
the
task/1223-mutation-observer-observe-options-validation
branch
from
9279da5
to
96b5ac4
Compare
|
|
|
@jajedidiah Unfortunately don't have an answer to that, awaiting for review from @capricorn86. |
capricorn86
approved these changes
Feb 25, 2024
romansp
deleted the
task/1223-mutation-observer-observe-options-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223 to better match DOM Standard.
Also added additional checks. All these throw
TypeErrorin Chrome:{ attributes: false, attributeOldValue: true }{ attributes: false, attributeFilter: ['class'] }{ characterData: false, characterDataOldValue: true }