Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default webpacker path to linked_dirs #2139

Merged
merged 1 commit into from Sep 12, 2023

Conversation

taketo1113
Copy link
Contributor

Summary

Remove default webpacker path to linked_dirs.
Webpacker deprecated from rails v7.0.

https://github.com/rails/webpacker

Short checklist

  • Did you run bundle exec rubocop -a to fix linter issues?
  • If relevant, did you create a test?
  • Did you confirm that the RSpec tests pass?

Copy link
Member

@mattbrictson mattbrictson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some thoughts:

  • Webpacker has been deprecated, but it is still widely used by existing Rails apps. However, this change only affects new apps (i.e. when cap install is run), so the potential negative impact to existing Capistrano-enabled Rails projects is minimal.
  • Webpack support for Rails lives on in a gem called shakapacker. However, this gem uses a different cache location (tmp/shakapacker1), so it will not be affected by this change.

Overall I think this is a good removal of cruft and should be safe. @leehambley @will-in-wi any objections?

Footnotes

  1. https://github.com/shakacode/shakapacker/blob/732ba010e6b54697875a19ad01e4975941a02c3f/lib/install/config/shakapacker.yml#L24

@leehambley
Copy link
Member

Looks great, thanks for taking the initiative everyone 🙌

@mattbrictson mattbrictson added the ✨ Feature Adds a new feature label Sep 12, 2023
@mattbrictson mattbrictson merged commit d3315db into capistrano:master Sep 12, 2023
15 of 17 checks passed
@taketo1113 taketo1113 deleted the remove-webpacker branch October 23, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants