Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from CircleCI to GitHub Actions; add Cucumber features to CI #2132

Merged
merged 13 commits into from May 27, 2023
Merged

Migrate from CircleCI to GitHub Actions; add Cucumber features to CI #2132

merged 13 commits into from May 27, 2023

Conversation

mattbrictson
Copy link
Member

@mattbrictson mattbrictson commented May 26, 2023 •
edited

This PR migrates our CI builds from CircleCI to GitHub Actions.

  • Older versions of Ruby (< 2.3) are no longer functional on Ubuntu 22.04, which is the default build environment. Work around this by running those old versions on Ubuntu 20.04. This means we have two sets of CI matrices: "spec" and "spec-legacy".
  • Added bundle exec rake features (using latest version of Ruby) to CI. This is possible because the macOS build environment provides the necessary vagrant support. With this change we now have better CI coverage than ever before.
  • Updated the branch protection rules so that all specs, features, rubocop, and danger must pass before a PR can be merged.
  • Changed README badge.

Fixes #2131

@mattbrictson mattbrictson changed the title First draft of GitHub Actions for CI Migrate from CircleCI to GitHub Actions; add Cucumber features to CI May 26, 2023
@mattbrictson mattbrictson added the 🏠 Housekeeping Non-user facing cleanup and maintenance label May 26, 2023
@mattbrictson mattbrictson marked this pull request as ready for review May 27, 2023 16:35
@mattbrictson mattbrictson merged commit 31e142d into master May 27, 2023
17 checks passed
@mattbrictson mattbrictson deleted the chores/github-actions branch May 27, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from CircleCI to GitHub Actions
1 participant
@mattbrictson