Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(layout settings): Update layout settings docs to reflect new grid variable #5483

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Mar 6, 2025

Done

Updates the layout settings documentation per the new 8 column grid

Fixes #5481, WD-19930

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

image

Sorry, something went wrong.

@webteam-app
Copy link

@jmuzina jmuzina force-pushed the WD-19930-grid-layout-settings-docs branch from b3c916a to 3ffbae6 Compare March 6, 2025 19:20
@jmuzina jmuzina marked this pull request as ready for review March 6, 2025 19:24
@jmuzina jmuzina requested a review from dgtlntv March 6, 2025 19:24
dgtlntv
dgtlntv previously approved these changes Mar 7, 2025
Copy link
Member

@dgtlntv dgtlntv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments I left lgtm :) Thank you!

@jmuzina jmuzina requested a review from dgtlntv March 7, 2025 14:16
@jmuzina jmuzina added the Review: Percy needed This PR needs a review of Percy for visual regressions label Mar 7, 2025
Copy link
Member

@dgtlntv dgtlntv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmuzina jmuzina merged commit 21fb5bb into main Mar 7, 2025
11 checks passed
@jmuzina jmuzina deleted the WD-19930-grid-layout-settings-docs branch March 7, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📝 Documentation changes or updates Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Layout settings docs incorrect values
3 participants