Revert "Change of the candid snap." #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b5ed0d.
mina1460
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 6b5ed0d made in #139. Note that some changes made since then in snapcraft.yaml have been maintained, particularly the way we stage the static files.
That PR introduced a set of scripts that:
/var/snap/candid/<revision> to/var/snap/candid/common`)snap set candid <config>.The first change broke backwards compatibility. This revert also removes the ability for 2.
Test instructions
Locally I made a tag
v1.12.3-dev, built the snap and released it tolatest/edgeon the snap store. Then I ransudo snap install candidto install the snap from latest/stable then ransudo snap refresh candid --channel=latest/edgeto refresh to the newly released snap and checked that Candid was still running as expected.