Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint new issues only #196

Merged
merged 1 commit into from Oct 4, 2023
Merged

lint new issues only #196

merged 1 commit into from Oct 4, 2023

Conversation

mina1460
Copy link
Contributor

@mina1460 mina1460 commented Oct 4, 2023

Description

Linter fails nearly on all PRs and people are forced to ignore it, which makes the concept of linting useless. Now each new PR would only show failures introduced by that PR.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests
  • Independent change*

@mina1460
lint new issues
b7dc31a 
Signed-off-by: mina1460 <mina146@aucegypt.edu>
alesstimec
alesstimec approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mina1460 mina1460 merged commit d914ea5 into canonical:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesstimec alesstimec alesstimec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mina1460 @alesstimec