Update Candid dockerfile #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotich
reviewed
Aug 29, 2023
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| GIT_COMMIT := $(shell git rev-parse --verify HEAD) | |||
| GIT_VERSION := $(shell git describe --dirty) | |||
| GO_VERSION := $(shell go list -f {{.GoVersion}} -m) | |||
There was a problem hiding this comment.
this means we are using the locally installed go version as the version to use in the docker container.
we then need to make sure the building host has the appropriate go version.
is it possible we set the golang version here directly?
There was a problem hiding this comment.
This actually grabs the go version defined in the go.mod rather than the one installed on the host. But you are correct, the host must have go installed in order to run the command.
brotich
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Candid Dockerfile to remove GVM (Go Version Manager). Also bumps the go version to 1.20
Engineering checklist
Check only items that apply