feat: remove 'textInput' event from UserEvent type()
#1645
Merged
+6
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
changed the title
type()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RN 0.75 no longer emits
textInputevents forTextInputcomponent.This PR brings User Event in line with this change and stops emitting
textInputevent intype()interaction.Note:
This is not considered a breaking change in RNTL, as the RNTL API did not cause the change, it's the underlying RN behavior (we are simulating) that is changing. The
textInputis relatively rarely used event (changeTextwould be the most popular one).If users tests start failing, it's actually a positive development, prompting user to notice the problem before discovering in production with RN 0.75 runtime behavior.
Test plan
Validated RN 0.75 behavior using side app created with RN CLI. Updated automated tests to match experimental behavior.