Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema not quoted on Postgres #633

Closed
pabloelcolombiano opened this issue Sep 13, 2023 · 2 comments
Closed

Schema not quoted on Postgres #633

pabloelcolombiano opened this issue Sep 13, 2023 · 2 comments
Milestone
3.x (CakePHP 4)

Comments

@pabloelcolombiano
Copy link
Contributor

When running on Postgres with a dashed schema (e.g. my-schema), the following line will throw an error, as the schema is not being quoted.

https://github.com/cakephp/migrations/blob/ac1d9566393c29e8c168c427c310f1ec6aad60cf/src/CakeAdapter.php#L62C79-L62C79
pabloelcolombiano added a commit to passbolt/migrations that referenced this issue Sep 13, 2023
@pabloelcolombiano
cakephp#633 Quote schema on postgres
b5d90c0
@othercorey othercorey added this to the 3.x (CakePHP 4) milestone Sep 13, 2023
@othercorey
Copy link
Member

Looks like it's an issue in both 3.x and 4.x.

pabloelcolombiano added a commit to pabloelcolombiano/migrations that referenced this issue Sep 14, 2023
@pabloelcolombiano
cakephp#633 Quote schema for PostgreSQL in the CakeAdapter
ec61235
pabloelcolombiano added a commit to pabloelcolombiano/migrations that referenced this issue Sep 14, 2023
@pabloelcolombiano
cakephp#633 Quote schema for PostgreSQL in the CakeAdapter
21061d6
dereuromark added a commit that referenced this issue Sep 14, 2023
@dereuromark
Merge pull request #635 from pabloelcolombiano/3.x
633cc85 
#633 Quote schema for PostgreSQL in the CakeAdapter
@othercorey
Copy link
Member

Closed in #635

othercorey pushed a commit that referenced this issue Sep 14, 2023
@pabloelcolombiano @othercorey
#633 Quote schema for PostgreSQL in the CakeAdapter
8b5b520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.x (CakePHP 4)
Development

No branches or pull requests
2 participants
@pabloelcolombiano @othercorey