bake migration_diff now supports --source for multiple database configs #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dereuromark
reviewed
Jun 26, 2023
dereuromark
reviewed
Jun 27, 2023
dereuromark
reviewed
Jun 27, 2023
ravage84
reviewed
Jun 29, 2023
…'plugin' and 'source' option into an array
… uses assertCount instead of assertEquals
… fully qualified name for $args param
ravage84
reviewed
Jun 30, 2023
Comment on lines
68
to
72
| $path = ROOT . DS . $this->pathFragment; | ||
| $path = ROOT . DS . $this->pathFragment . DS . $args->getOption('source') . DS; | ||
| if ($this->plugin) { | ||
| $path = $this->_pluginPath($this->plugin) . $this->pathFragment; | ||
| $path = $this->_pluginPath($this->plugin) . $this->pathFragment . DS . $args->getOption('source') . DS; |
There was a problem hiding this comment.
$args->getOption('source') could be extracted into an intermediate variable to improve readability and reduce redunant calls.
…tion('source') . DS' into an intermediate variable
ravage84
approved these changes
Jul 3, 2023
|
Is there anything blocking this? |
|
Released in Migrations 3.9, thanks! |
ndm2
added a commit
that referenced
this pull request
Sep 22, 2023
#618 changed how the path for the baked files is being built.
|
Does not seem to work for me. cakephp/cakephp: 4.4.18,
|
|
@Rakasch You are using |
|
@ndm2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a souce option for bake migration_diff. migration_diff now supports multiple target folders for the generated migration.
This is especially what was requested in issue #608 and it also bothered our company.
This has now been built on top of the 3.x branch (because we need it theres) but should probably be merged to 4.x as well.
We added tests for the option and also executed CS before opening the PR, both are running without errors.
We appreciate your feedback if there is more to change to be compliant with the contribution guidelines.