Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use physical index to removePair #601

Merged
merged 1 commit into from Feb 26, 2024
Merged

fix: use physical index to removePair #601

merged 1 commit into from Feb 26, 2024

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Feb 23, 2024

fix #600

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.58%. Comparing base (eb25ba2) to head (456f13d).

Files Patch % Lines
ast/node.go 71.42% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   73.80%   77.58%   +3.77%     
==========================================
  Files          62       83      +21     
  Lines        8266    11538    +3272     
==========================================
+ Hits         6101     8952    +2851     
- Misses       1826     2188     +362     
- Partials      339      398      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY AsterDY merged commit 0e87afb into main Feb 26, 2024
33 checks passed
@AsterDY AsterDY deleted the fix/issue_600 branch February 26, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unset() misbehavior on v1.11.0-x
3 participants