Restrict the preview1 implementation of fd_read to one iovec #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
requested review from
alexcrichton and
a team
and removed request for
a team
|
I was initially confused reading over this trying to piece together how this wasn't covered by #8353 but that was Mind adding a test for this? Also, can you update the filter here to be the same as #8353 where it searches for the first non-empty buffer rather than the first buffer? |
…8277 Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
elliottt
force-pushed
the
trevor/fix-p1-fd-read-mut-borrows
branch
from
60df49b
to
903aff1
Compare
|
I added a test, and verified that it failed without the fix to |
alexcrichton
approved these changes
Apr 19, 2024
elliottt
force-pushed
the
trevor/fix-p1-fd-read-mut-borrows
branch
from
903aff1
to
27e1a96
Compare
elliottt
force-pushed
the
trevor/fix-p1-fd-read-mut-borrows
branch
from
27e1a96
to
d25e9b2
Compare
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Apr 22, 2024
…ealliance#8415) * We can only have one mutable borrow at a time after bytecodealliance#8277 Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com> * Add a test like pread/pwrite, but for read/write --------- Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the wasi-common implementation of
fd_readfor preview1, switch to only reading the first iovec given in a vectored read. This avoids issues with Wiggle's runtime borrow-checker implemented in #8277, which would cause the reads to unconditionally fail when two mutable borrows were taken out on the same memory.While it's not as efficient to perform a single read at a time, it is also valid, as read never promises to read all of the vectors provided.
Co-authored-by: Nick Fitzgerald fitzgen@gmail.com