New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winch: Switch to using cranelift for all trampolines #8109
winch: Switch to using cranelift for all trampolines #8109
Conversation
e8412a7
to
c2d6f3e
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
c2d6f3e
to
b5162c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
One thing that I wanted to note: Winch is still missing support for emit_trampolines_for_array_call_host_func
, would it make sense to implement that function in this PR? I think a follow-up also works!
d25b23b
to
30e21ba
Compare
f0f5a9a
to
f566a6a
Compare
f566a6a
to
e56d30d
Compare
c47c87b
to
41abec2
Compare
…e#8109) * Return the last result through registers in the winch calling convention * Switch winch over to using cranelift for all trampolines * Fix unused code warnings
prtest:full
41abec2
to
55c47ff
Compare
…e#8109) * Return the last result through registers in the winch calling convention * Switch winch over to using cranelift for all trampolines * Fix unused code warnings
Remove the winch MacroAssembler-based trampolines, and reuse the trampoline-generation from the
wasmtime-cranlift
crate instead.Fixes #8098