Replace Exec task with Unzip task #267
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes dependency on having unzip in path
peterhuene
approved these changes
Jul 10, 2023
peterhuene
reviewed
Jul 10, 2023
* CI build failed
|
@peterhuene This is it from me. Feel free to merge if and when it suits you. |
|
@henrikrxn thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on having unzip in path
How did I test it?
The only test I have run is on Windows 11 building under Powershell 7.3.5
PS> dotnet build .\Wasmtime.slnIf your CI does not handle the other platforms then let me know if you feel additional testing is needed on my side.
Fixes #266