Compatibility with MkDocs 1.5 change to extra_javascript
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upcoming MkDocs 1.5.0 release, `extra_javascript` is no longer a plain list of strings. This edit makes the plugin compatible with both the new behavior and old behavior of MkDocs. Otherwise currently this plugin **fails to update the script paths** with upcoming 1.5.
|
Pinging @wilhelmer to make sure this gets noticed (sorry again) |
|
Thanks for providing both the problem and the solution! 😄 Just kidding, appreciate the PR. Looks good to me. |
|
@byrnereese Please publish version 0.7.0 on PyPI. Thanks! |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming MkDocs 1.5.0 release,
extra_javascriptis no longer a plain list of strings. This edit makes the plugin compatible with both the new behavior and old behavior of MkDocs. Otherwise currently this plugin fails to update the script paths with upcoming 1.5.Sorry about the (upcoming) breakage, and this will also require a release.