fix: remove embedfield omitempty #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove omitempty from Name/value since the Discord API requires both to be submitted. Fixes: bwmarrin#726
|
May require additional PRs on other structs against the API to cleanup/remove unnecessary omitempty occurrences. |
FedorLap2006
added
fix
FedorLap2006
approved these changes
Oct 23, 2022
FedorLap2006
added
semver ignore
LWCoder
pushed a commit
to AtTheTavern/discordgo
that referenced
this pull request
Apr 11, 2023
Remove omitempty from Name/value since the Discord API requires both to be submitted. Fixes: bwmarrin#726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove omitempty from Name/value since the Discord API requires both to be submitted.
https://discord.com/developers/docs/resources/channel#embed-object
Fixes: #726