Overwrite entire emoji list on GuildEmojiUpdate #1261
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted emoji should be deleted from cache
FedorLap2006
requested changes
Oct 19, 2022
|
I fixed it, can you review please? |
There was a problem hiding this comment.
After thinking a bit more about this, it would have actually made sense to separate out the GuildEmojisUpdate (that's why initially I have deleted my comment). It was probably a miscommunication.
Nonetheless, I'll revert the inline commit in another PR, as don't wanna hold off this one more.
Thanks for the contribution!
LWCoder
pushed a commit
to AtTheTavern/discordgo
that referenced
this pull request
Apr 11, 2023
* Overwrite entire emoji list on GuildEmojiUpdate deleted emoji should be deleted from cache * Updating GuildEmojis inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted emoji should be deleted from cache