Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignored update after error triggered on component mount #85

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix: ignored update after error triggered on component mount #85

merged 2 commits into from
Mar 2, 2021
+50 −5

Conversation

wild-lotus
Copy link
Contributor

What:

  • Fix ignored update via resetKeys after ErrorBoundary error state is triggered on component mount.
  • Add test for this case.
  • I also needed to update a couple of snapshots to make it. That was strange to me.

Why:

Closes #74 and Closes #84

How:

Adding extra check of this.updatedWithError on componentDidMount

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged

Sorry, something went wrong.

@wild-lotus
Copy link
Contributor Author

@kentcdodds did you have a chance to have a look at this PR?

kentcdodds
kentcdodds approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me 👍

@kentcdodds kentcdodds merged commit 125d9e9 into bvaughn:master Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@wild-lotus @kentcdodds