Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The class GeneratedAppGlideModuleImpl generated by ksp does not register the LibraryGlideModule subclass #5269

Closed
jenverstraete opened this issue Aug 28, 2023 · 2 comments

Comments

@jenverstraete
Copy link

Referencing the bug that was posted here:
#5043

@sjudd am I missing something or is more investigation needed on this bug, because when I use the sample project from issue 5043 (https://github.com/lyh8577/GlideDemo-issue-5043), update the dependencies in the KSP build.gradle file to a glide version where this issue should be fixed (4.15.1 or 4.16.0) and re-build and check the generated GeneratedAppGlideModuleImpl.kt, the exact same issue still persists. Methods like getExcludedModuleClasses are still absent from the generated file. As a result, it is not possible to use Glide with KSP while trying to show images from a firebase reference.

ksp("com.github.bumptech.glide:ksp:4.15.1")
implementation("com.github.bumptech.glide:okhttp3-integration:4.15.1")

Generated class looks like:

_internal class GeneratedAppGlideModuleImpl(
@Suppress("UNUSED_PARAMETER")
context: Context,
) : GeneratedAppGlideModule() {
private val appGlideModule: KspAppGlideModule
init {
appGlideModule = KspAppGlideModule()
}

public override fun registerComponents(
context: Context,
glide: Glide,
registry: Registry,
): Unit {
OkHttpLibraryGlideModule().registerComponents(context, glide, registry)
appGlideModule.registerComponents(context, glide, registry)
}

public override fun applyOptions(context: Context, builder: GlideBuilder): Unit {
appGlideModule.applyOptions(context, builder)
}

public override fun isManifestParsingEnabled(): Boolean = false
}_

@sjudd
Copy link
Collaborator

sjudd commented Sep 3, 2023

Seems like it works for me?
image
image

@sjudd sjudd closed this as completed Sep 3, 2023
@sjudd
Copy link
Collaborator

sjudd commented Sep 3, 2023

The project structure may obfuscate things? I think I ended up needing to make changes in the app module to include ksp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants