Assign Vars value to metrics #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1581 +/- ##
==========================================
+ Coverage 77.81% 78.38% +0.57%
==========================================
Files 58 57 -1
Lines 6626 6582 -44
==========================================
+ Hits 5156 5159 +3
+ Misses 1470 1423 -47
☔ View full report in Codecov by Sentry. |
Comment on lines
225
to
242
| "vars": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "value" | ||
| ], | ||
| "properties": { | ||
| "type": { | ||
| "type": "string", | ||
| "description": "Specify the type of the variable", | ||
| "enum": [ | ||
| "str", | ||
| "int", | ||
| "float" | ||
| ] | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Please remove this we have a definition for environment variables that work same as variables. This is defined in same file
"env": {
"type": "object",
"description": "One or more key value pairs for an environment (key=value)",
"minItems": 1,
"items": {
"type": "object",
"minItems": 1,
"propertyNames": {
"pattern": "^[A-Za-z_][A-Za-z0-9_]*$"
}
}
},| @@ -199,13 +199,17 @@ | |||
| "regex": { | |||
| "$ref": "#/definitions/regex" | |||
| }, | |||
| "vars": { | |||
| "$ref": "#/definitions/vars" | |||
There was a problem hiding this comment.
change this to #/definitions/env that should fix the issue.
add support for vars to definitions.schema.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull is to assign metrics from variables defined in tests. A property name vars is defined with value for vars.