Cucumber emoji is duplicated

[jufemaiz]

There are currently two cucumber emoji:

• 1 from Apple » https://emojipedia.org/cucumber/
• 1 custom » https://github.com/buildkite/emojis/blob/master/img-buildkite-64.json#L962-L969 + https://github.com/buildkite/emojis/blob/master/img-buildkite-64/cucumber.png

Thoughts?

[keithpitt]

Perhaps we should rename the custom one to cucumber_ruby or something? I remember when I first added the cucumber emoji, the Apple one didn't exist.

Even though cucumber currently resolves to the old one, I think it's an easy change for peeps to make if they want the old one back. And it's probably better to be consistent with actual emoji usage. What do you think @jufemaiz?

[jufemaiz]

I'd probably go with your recommendation (happy to PR). I think it makes most sense (standard emoji as primary source » custom buildkite emoji as secondary source).

[ticky]

I’ve been wanting to address this, I actually recently implemented duplicate checking and this always comes up in its results!

We can’t rename the Unicode emoji, so renaming cucumber-the-tool would make sense, the trouble is that the custom emoji takes precedence, so renaming it means we retroactively change the existing emoji to the Unicode one, which is probably a bit weird.

I don’t think :cucumber_ruby: makes much sense as the tool supports about a dozen languages. Maybe :cucumber_specs:?

If you need a Unicode cucumber now, you can always just type a Unicode cucumber (🥒) and it’ll work fine! 👌🏼

[jufemaiz]

@ticky it was your checker! Nice! Agree regarding :cucumber_specs: but this was more to highlight the name conflict for the BK team to work out how to resolve 😀👍

[ticky]

as the BK team’s resident emoji (a-little-too-)enthusiast, I think I’ve thus worked out how to resolve it 😉