-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewInstancesProtectedFromScaleIn
causing ASGs to take ages to update.
#977
Comments
Ah just looking around, maybe i'm in fact being re-bitten by #927? In any case i'm not convinced that the instance protection thing is good for us. |
Hey hey @toothbrush. Thanks for reporting, we'll look into it! |
Somewhat related is #768 Also been working to create custom AMIs and update the stack via |
I've run into this issue myself when i want to scale down a stack rapidly (~400 instances to 0) via manually changing the ASG desired count/min/max values. It hasn't been a major issue for me as this is typically only done when launching new stacks to replace old stacks. I simply go to the instance management tab for the ASG in the AWS console and manually remove scale-in protection to speed up the scale down. |
I am running into this issue with v5.9.0 of the stack and have had to repeatedly go into the AWS console to manually disable protection for instances in the old stacks to allow the update to complete. This is obnoxious! It makes even the smallest configuration changes a major PITA, especially when some stacks have thousands of instances and AWS only allow removal of scale-in protection in batches of 50... Please fix this asap. |
We made a hacky but effective fix for this problem by co-opting the eg:
|
Good day! 馃憢
Describe the bug
We use realestate's
stackup
to manage rollouts of theaws-stack.yml
you provide. Mostly works great. In 178c253 you have enabledNewInstancesProtectedFromScaleIn: true
to the ASG, but the behaviour i'm now seeing is that when i make a change to the AWS Elastic stack (e.g. an updated AMI ID), the old ASG takes ages (1h+) to delete/stabilise, since the members are protected from scale-in.Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Previously, updates were pretty snappy because the old ASG members would just be terminated.
Stack parameters (please complete the following information):
us-east-1
v5.7.2
The text was updated successfully, but these errors were encountered: