bk local run - support if conditions - currently ignoring them

[drnic]

https://buildkite.com/docs/pipelines/conditionals

steps:
  - command: "echo --- All good. Nice one."
    label: ":git:"
    if: build.branch == 'master'
  - command: "echo --- ERROR this shouldn't run; exit 1"
    label: ":git:"
    if: build.branch != 'master'

When I run this pipeline.yml it runs both steps; but it should only run one or the other.

@keithpitt is this something that should work, or one of those "its annoying to implement everything in ruby + golang" (my words not yours) gaps ;)

[gustavderdrache]

One follow-on issue with this is that bk run doesn't reject this invalid step definition, which tripped me up when I was trying to use it to double-check that I had my conditionals right:

steps:
   - label: Test PRs
     command: echo hello
     branches: "!main"
     if: build.pull_request.id != null

[pda]

is this something that should work, or one of those "its annoying to implement everything in ruby + golang" (my words not yours) gaps

I think that is the truth.

Maybe worth noting that https://github.com/buildkite/conditional does exist as a Go implementation of Buildkite's server-side conditional evaluation, however it may not be complete, it's never been integrated, and may not always behave the same. Still, a good starting point.

[GMNGeoffrey]

This is a frustrating limitation, especially when it doesn't even say what is going on. I'm using the local runner to debug my pipelines. Being able to do that locally is super helpful, but if it's missing features like this, that's a major drawback. In this case it was especially annoying because I was trying to use the if condition to skip a step that fails when run locally because buildkite-agent pipeline upload --replace isn't implemented locally.

its annoying to implement everything in ruby + golang

😱 Dare I ask why things are implemented in Ruby...?